Enhance SBOM and JDK file check

[sophia-guo]

Fixes #4079

If no SBOM and JDK file available fail the job.

Related #4079

[sophia-guo]

https://ci.adoptium.net/job/Test_openjdk21_hs_special.system_x86-64_windows/26/console

[smlambert]

LGTM

One question, did you intend to lose the indentation within the ifndef blocks of the .mk file?

[karianna]

whitespace probably needs fixing

[sxa]

https://ci.adoptium.net/job/Test_openjdk21_hs_special.system_x86-64_windows/26/console

I was expecting that link to be a re-run with the fix that showed the fix, but that is my original failing job link :-)

I guess it's not easy to run a re-test with an updated openjdk-build repo, so we can integrate this and then I can run the test against it again

Since it's been flagged by the other two above, I think it's worth fixing the whitespace issues (Blocking for now in case someone else merges this before you see the comments)

[sophia-guo]

https://ci.adoptium.net/job/Test_openjdk21_hs_special.system_x86-64_windows/26/console is using my personal branch. @sxa

[sophia-guo]

https://ci.adoptium.net/view/Test_grinder/job/Grinder/11936/console

This failure in makefile will fail the job and hence no other tests in same level will run and no test output will be archived. Currently no other tests in special.system, but it's not a good solution. Change it to draft.

[sxa]

https://ci.adoptium.net/job/Test_openjdk21_hs_special.system_x86-64_windows/26/console is using my personal branch. @sxa

Ah yes - I hadn't looked at VENDOR_TEST_REPO before and I was searching the log for ERROR! as per:

error ERROR! NO SBOM_FILE AVAILABLE

but that doesn't appear. We only get:

21:32:32  reproducible.mk:17: *** no SBOM_FILE available.  Stop.

(Maybe it was changed since you ran the job). But LGTM now - thanks for the fix, but I agree on your last comment that it would be good for it to fail in a different way if possible.

[sophia-guo]

Updated. Print ERROR message and usage infor.
https://ci.adoptium.net/job/Grinder/11939/ - fail the test itself with ERROR message.
https://ci.adoptium.net/job/Grinder/11943/ - manually abort after the test start running.

[sxa]

Updated. Print ERROR message and usage infor. https://ci.adoptium.net/job/Grinder/11939/

Just a minor point - it might be nicer if the error was inside the Running test block, but otherwise this LGTM and I'm fine with it going in like this!

15:12:19  ERROR! NO SBOM_FILE AVAILABLE
15:12:19  
15:12:19  ===============================================
15:12:19  Running test Rebuild_Same_JDK_Reproducibility_Test_win_0 ...
15:12:19  ===============================================

[sophia-guo]

Inside the running test: it shows the usage of windows_repro_build_compare.sh information, which means parameters are missing. ERROR! NO SBOM_FILE AVAILABLE helps to know which parameter is missing.

10:12:20  Usage: C:/jenkins/workspace/Grinder/aqa-tests/\system\reproducibleCompare\windows_repro_build_compare.sh SBOM_URL/SBOM_PATH JDKZIP_URL/JDKZIP_PATH
10:12:20  
10:12:20  1. SBOM_URL/SBOM_PATH - should be the FULL path OR a URL to a Temurin JDK SBOM JSON file in CycloneDX Format
10:12:20      eg. https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.2%2B13/OpenJDK21U-sbom_x64_windows_hotspot_21.0.2_13.json
10:12:20  
10:12:20  2. JDKZIP_URL/JDKZIP_PATH - should be the FULL path OR a URL to a Temurin Windows JDK Zip file
10:12:20      eg. https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.2%2B13/OpenJDK21U-jdk_x64_windows_hotspot_21.0.2_13.zip
10:12:20  
10:12:20  3. REPORT_DIR - should be the FULL path OR a URL to the output directory for the comparison report
1