Add potential boot location for jdk10 on orka mac #4071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Farley <[email protected]>
Currently, the JDK10 boot directory in the Orka node template is called jdk-10 instead of the correct jdk10. This change allows us to tolerate this setup until we are able to regenerate the Orka node template. Signed-off-by: Adam Farley <[email protected]>
This was referenced Dec 2, 2024
Open
|
This PR is linked to this issue but does not resolve it. |
|
@adamfarley after the template is updated, the bootjdk will be found in /Library/Java/JavaVirtualMachines/jdk${JDK_BOOT_VERSION}/Contents/Home/bin/javac? (without the hyphen) |
|
Probably, yes. That matter is being discussed here. Feel free to chip in. This PR is to cover the short-term fix until we can agree on the long-term fix. |
Haroon-Khel
approved these changes
Dec 3, 2024
andrew-m-leonard
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us accommodate the unexpected boot jdk location on Orka nodes until the template can be updated.