Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Windows SBOM artifact filename #3466

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

andrew-m-leonard
Copy link
Contributor

Fixes #3464

Ensure SBOM artifact filename is correct on Windows builds.

@andrew-m-leonard andrew-m-leonard self-assigned this Aug 31, 2023
@andrew-m-leonard andrew-m-leonard requested a review from sxa September 1, 2023 08:21
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment removed

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably have just gone with this to squash them both and skip the if clause to make the code simpler, but I'm ok with it as-is too if you'd rather not change it.

sbomTargetName="${sbomTargetName//\.zip/}"
sbomTargetName="${sbomTargetName//\.tar\.gz/}"

@andrew-m-leonard
Copy link
Contributor Author

I'd probably have just gone with this to squash them both and skip the if clause to make the code simpler, but I'm ok with it as-is too if you'd rather not change it.

sbomTargetName="${sbomTargetName//\.zip/}"
sbomTargetName="${sbomTargetName//\.tar\.gz/}"

Yeah, I did think of doing that to start with, but thought better to be more precise, i'll go with what I have, thanks

@andrew-m-leonard andrew-m-leonard merged commit 4b030da into adoptium:master Sep 1, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows sbom artifact has incorrect filename
4 participants