Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: support orgs with default: read permissions #486

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jan 23, 2024

Without this change, forks that default to readonly permissions fail (By default, when you create a new organization, GITHUB_TOKEN only has read access for the contents and packages scopes.) with:

Invalid workflow file: .github/workflows/dependabot-auto-merge.yml#L5
The workflow is not valid. .github/workflows/dependabot-auto-merge.yml (Line: 5, Col: 3): Error calling workflow 'adoptium/.github/.github/workflows/dependabot-auto-merge.yml@main'. The workflow is requesting 'contents: write, pull-requests: write', but is only allowed 'contents: read, pull-requests: none'.

With this change, the workflow is deemed valid (and could thus do whatever it does).

@jsoref jsoref force-pushed the ci-dependabot-forks-default-readonly branch from d0310d7 to 1757cc1 Compare January 23, 2024 13:41
@gdams gdams merged commit cb16099 into adoptium:main Jan 24, 2024
57 checks passed
@jsoref jsoref deleted the ci-dependabot-forks-default-readonly branch January 24, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants