Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary packages from docker files #460

Merged
merged 7 commits into from
Nov 9, 2023
Merged

Conversation

gdams
Copy link
Member

@gdams gdams commented Oct 30, 2023

closes: #458

Confirmed that zlib is no longer required as we bundle it:

docker run -it --name  test-container test-image /bin/bash
6b5acded951e:/# java -version
openjdk version "21.0.1" 2023-10-17 LTS
OpenJDK Runtime Environment Temurin-21.0.1+12 (build 21.0.1+12-LTS)
OpenJDK 64-Bit Server VM Temurin-21.0.1+12 (build 21.0.1+12-LTS, mixed mode, sharing)
6b5acded951e:/# apk del apk-tools -s
WARNING: opening from cache https://dl-cdn.alpinelinux.org/alpine/v3.18/main: No such file or directory
WARNING: opening from cache https://dl-cdn.alpinelinux.org/alpine/v3.18/community: No such file or directory
(1/4) Purging apk-tools (2.14.0-r2)
(2/4) Purging ca-certificates-bundle (20230506-r0)
(3/4) Purging ssl_client (1.36.1-r2)
(4/4) Purging libssl3 (3.1.3-r0)
OK: 47 MiB in 43 packages
6b5acded951e:/# java -version
openjdk version "21.0.1" 2023-10-17 LTS
OpenJDK Runtime Environment Temurin-21.0.1+12 (build 21.0.1+12-LTS)
OpenJDK 64-Bit Server VM Temurin-21.0.1+12 (build 21.0.1+12-LTS, mixed mode, sharing)

Also converted the alpine entrypoint.sh to not require bash

@gdams gdams changed the title remove zlib and libretls from alpine images remove unnecessary packages from docker files Oct 30, 2023
@gdams gdams marked this pull request as draft October 31, 2023 08:49
@gdams gdams force-pushed the zlib branch 2 times, most recently from 4a71735 to f58a094 Compare November 1, 2023 15:19
@gdams gdams force-pushed the zlib branch 2 times, most recently from f01c6e5 to daa6dad Compare November 7, 2023 08:37
@gdams gdams marked this pull request as ready for review November 7, 2023 08:58
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions and a suggestion on the comment about the bash->sh change.

17/jdk/alpine/entrypoint.sh Outdated Show resolved Hide resolved
17/jdk/centos/Dockerfile Show resolved Hide resolved
17/jre/alpine/entrypoint.sh Outdated Show resolved Hide resolved
21/jdk/alpine/entrypoint.sh Outdated Show resolved Hide resolved
21/jre/alpine/entrypoint.sh Outdated Show resolved Hide resolved
8/jdk/alpine/entrypoint.sh Outdated Show resolved Hide resolved
8/jre/alpine/entrypoint.sh Outdated Show resolved Hide resolved
docker_templates/alpine-linux.Dockerfile.j2 Show resolved Hide resolved
@gdams
Copy link
Member Author

gdams commented Nov 9, 2023

@sxa updated ptal

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now - thanks.

@gdams gdams merged commit a6be406 into adoptium:main Nov 9, 2023
56 checks passed
@tellison
Copy link
Contributor

This was discussed at the PMC meeting on November 8th and minuted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assess current set of dependencies in dockerfiles to determine if they are still needed
4 participants