Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate updater to use jinja templating #447

Merged
merged 6 commits into from
Oct 25, 2023
Merged

migrate updater to use jinja templating #447

merged 6 commits into from
Oct 25, 2023

Conversation

gdams
Copy link
Member

@gdams gdams commented Oct 24, 2023

No description provided.

This was linked to issues Oct 24, 2023
config/hotspot.config - could convert to YAML, JSON or some other parseable language #7
Closed
Refactor common_functions.sh to shell script standards #6
Closed
karianna
karianna reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be additions like:

amd64|i386:x86-64)
ESUM='7b175dbe0d6e3c9c23b6ed96449b018308d8fc94a5ecd9c0df8b8bc376c3c18a';
BINARY_URL='https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.9%2B9/OpenJDK17U-jdk_x64_linux_hotspot_17.0.9_9.tar.gz';
;; \

     I suspect that should be split out?

@gdams
Copy link
Member Author

gdams commented Oct 25, 2023

Seems to be additions like:

amd64|i386:x86-64) \

     ESUM='7b175dbe0d6e3c9c23b6ed96449b018308d8fc94a5ecd9c0df8b8bc376c3c18a'; \

     BINARY_URL='https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.9%2B9/OpenJDK17U-jdk_x64_linux_hotspot_17.0.9_9.tar.gz'; \

     ;; \

     

     I suspect that should be split out?

I felt unsure what the best path forward was here. I think it makes sense to remove the dockerfile updates completely to make the PR easier to review

tellison
tellison approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@tellison tellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions.

docker_templates/partials/header.j2 Outdated Show resolved Hide resolved
generate_dockerfiles.py Show resolved Hide resolved
jerboaa
jerboaa approved these changes Oct 25, 2023
View reviewed changes
Copy link

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK, though fairly complex.

@gdams gdams merged commit 5d4f312 into adoptium:main Oct 25, 2023
57 checks passed
@gdams gdams mentioned this pull request Oct 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karianna karianna karianna left review comments

@tellison tellison tellison approved these changes

@jerboaa jerboaa jerboaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@gdams @karianna @jerboaa @tellison