Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set system.dev with additional label and vendors info #908

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

sophia-guo
Copy link
Contributor

Fix issues mentioned in adoptium/temurin-build#3587

Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/github/workspace/pipelines/build/common/openjdk_build_pipeline.groovy
401 error The current scope already contains a variable of the name vendorTestBranches
@ line 401, column 33. NglParseError
402 error The current scope already contains a variable of the name vendorTestRepos
@ line 402, column 33. NglParseError

@sophia-guo
Copy link
Contributor Author

Updated @karianna

@smlambert
Copy link
Contributor

Now #929 is merged, this can come in, needs a rebase @sophia-guo

@sophia-guo
Copy link
Contributor Author

Didn't realize that this PR is not merged until I noticed the issue with https://ci.adoptium.net/job/Test_openjdk23_hs_dev.system_x86-64_linux/3/.

Rebased.

@sophia-guo sophia-guo merged commit f8f45f4 into adoptium:master Feb 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants