Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare agents within a stage to release the agent when stage is over #904

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

sophia-guo
Copy link
Contributor

@sophia-guo sophia-guo commented Jan 30, 2024

Avoid possible dead lock if both stages are requiring the agent with same label and there is only one agent with the label available

Also adding the timeout in case any unexpected dead lock.

Fixes #905

Avoid possible dead lock if both stages are requiring the agent with
same label and there is only one agent with the label available

Also adding the timeout in case any unexpected dead lock.

Signed-off-by: Sophia Guo <[email protected]>
@sophia-guo sophia-guo self-assigned this Jan 30, 2024
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@sophia-guo
Copy link
Contributor Author

@steelhead31 is there any issue opened so I can attach this PR?

@steelhead31
Copy link
Contributor

steelhead31 commented Jan 31, 2024

@steelhead31 is there any issue opened so I can attach this PR?

I've created #905 for this issue, and attached this PR :)

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophia-guo sophia-guo merged commit 1a3b049 into adoptium:master Jan 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

WIP: Deadlocking Of Build Nodes Encountered During Release Cycle - Related To Reproducibie Build Jobs.
3 participants