Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable arm32/win32 hotspot variant builds #899

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

sxa
Copy link
Member

@sxa sxa commented Jan 26, 2024

While we no longer ship these at Temurin I believe it is worthwhile to continue to build these for a Hotspot variant in order to allow us to see if the platform is receiving any PRs that break the build that are potentially going to be backported. We've seen this recently for Win32. Since these are hotspot variant builds, they wil lnot be published as nightlies so are only for our own use and allow us to compare functionality between these and other architectures if required.

Another option would be to run these through the evaluation pipeline, but that doesn't feel right since that should be for platforms which we plan to make available.

Related: #525

@sxa sxa self-assigned this Jan 26, 2024
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@sxa sxa merged commit a671151 into adoptium:master Jan 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants