Add release Tap collection and upload url #1134
Conversation
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
| artifactsToCopy = URLEncoder.encode(artifactsToCopy, 'UTF-8') | ||
| def javaVersion=determineReleaseToolRepoVersion() | ||
| releaseToolUrl += "&VERSION=${javaVersion}&TAG=${tag}&ARTIFACTS_TO_COPY=${artifactsToCopy}" | ||
| releaseSummary.appendText("<li><a href=${releaseToolUrl}> RELEASE TEST RESULTS TAPs Link</a></li>") |
There was a problem hiding this comment.
Please add a flag to control this. This will not work for Semeru.
- we do not use ci-jenkins-pipelines to trigger release testing anymore
- we do not have TAP_Collection job
There was a problem hiding this comment.
We've used "If Adopt" code before. You'll have to test to see if it works in this file.
https://github.com/search?q=repo%3Aadoptium%2Fci-jenkins-pipelines%20%22JENKINS_URL.contains(%27adopt%27)%22&type=code
|
cc @AdamBrousseau for awareness |
|
Updated to work with adoptium only |
| @@ -1034,6 +1034,21 @@ class Builder implements Serializable { | |||
| if (publish || release) { | |||
| if (release) { | |||
| context.println 'NOT PUBLISHING RELEASE AUTOMATICALLY, PLEASE SEE THE RERUN RELEASE PUBLISH BINARIES LINKS' | |||
| if (context.HUDSON_URL.contains('adoptium')) { | |||
There was a problem hiding this comment.
I'm guessing HUDSON_URL works because it is already being used here. But I would think we should probably use JENKINS_URL. I'm not sure if HUDSON_URL will go away someday.
| @@ -788,7 +788,7 @@ class Builder implements Serializable { | |||
| def osArch = 'all available OS&ARCHs' | |||
| def artifactsToCopy = '**/temurin/*.tar.gz,**/temurin/*.zip,**/temurin/*.sha256.txt,**/temurin/*.msi,**/temurin/*.pkg,**/temurin/*.json,**/temurin/*.sig' | |||
| def dryRun = false | |||
| def String releaseToolUrl = "${context.HUDSON_URL}job/build-scripts/job/release/job/refactor_openjdk_release_tool/parambuild?" | |||
| def String releaseToolUrl = "${context.JENKINS_URL}job/build-scripts/job/release/job/refactor_openjdk_release_tool/parambuild?" | |||
There was a problem hiding this comment.
Please use def or String, but not both. See https://groovy-lang.org/style-guide.html#_def_and_type
sophia-guo
requested review from
smlambert
and removed request for
AdamBrousseau
| @@ -1034,6 +1034,21 @@ class Builder implements Serializable { | |||
| if (publish || release) { | |||
| if (release) { | |||
| context.println 'NOT PUBLISHING RELEASE AUTOMATICALLY, PLEASE SEE THE RERUN RELEASE PUBLISH BINARIES LINKS' | |||
| if (context.JENKINS_URL.contains('adoptium')) { | |||
| releaseSummary.appendText('</ul>', false) | |||
| releaseSummary.appendText("<b>TAPs COLLECTION and REALEASE:</b><ul>") | |||
There was a problem hiding this comment.
| releaseSummary.appendText("<b>TAPs COLLECTION and REALEASE:</b><ul>") | |
| releaseSummary.appendText("<b>TAP files COLLECTION and RELEASE:</b><ul>") |
Add release Tap collection and upload url to ease the Tap file collection process