-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also build jtreg version 7.4+1 #1051
Conversation
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a nit, please change the variable to match other versions, like 7.3+1
and 7.2+1
. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@andrew-m-leonard Is this the same linter failure that should be fixed by your recent update? I did a merge but it still seems to be failing. |
I'm not sure how to interpret the log of the |
Signed-off-by: Keith W. Campbell <[email protected]>
There's a reasonable chance it's nothing to do with your PR ... And yes I completely agree that the error need is somewhat lacking in comprehensibility ... I'm quite tempted to just merge this but since Andrew had looked at the linter this week it would be good to have his ok first. |
I suspect there's some new SHELL_SHFMT syntax in super-linter 6.6.0. I'll look at shaell linter'ing separately |
Needed for the head stream (Java 24), otherwise testing fails
See https://openj9-jenkins.osuosl.org/job/Grinder/3673/.