-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jdk23 and add jdk24 pipeline configurations #1047
Update jdk23 and add jdk24 pipeline configurations #1047
Conversation
Signed-off-by: Andrew Leonard <[email protected]>
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok.
run tests |
Signed-off-by: Andrew Leonard <[email protected]>
PR TESTER RESULT ❎ Some pipelines failed or the job was aborted! ❎ |
run tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should hold off on this until #1045 is merged, and then rebase on that change to ensure that the AIX changes are included here.
PR TESTER RESULT ❎ Some pipelines failed or the job was aborted! ❎ |
AIX PRs merged, so if you can add in the label changes to the new versions in this PR that would be appreciated :-) |
Signed-off-by: Andrew Leonard <[email protected]>
run tests |
@sxa updated.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :-)
PR TESTER RESULT ✅ All pipelines passed! ✅ |
Note: Had to fix build_base_file.groovy, as the pr-tester is failing due to missing logic for AQAvit archiving when no AQA tests are run...