Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trigger_beta_build and daily Slack status jobs to handle jdk(head) version branching #1046

Merged
merged 13 commits into from
Jun 20, 2024

Conversation

andrew-m-leonard
Copy link
Contributor

Fixes adoptium/temurin-build#3856

  • Correct EA trigger jenkins job to correctly find and build jdk(head) version tags
  • Correct daily Slack status to report correct jdk(head) version build status

@andrew-m-leonard andrew-m-leonard self-assigned this Jun 18, 2024
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@github-actions github-actions bot added code-tools Issues that are miscellaneous enhancements or bugs with our utilities that assist our build scripts jenkins-pipeline labels Jun 18, 2024
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok :)

Signed-off-by: Andrew Leonard <[email protected]>
Signed-off-by: Andrew Leonard <[email protected]>
@andrew-m-leonard
Copy link
Contributor Author

@sxa i've upgraded super-linter to 6.6.0, as the current version 5.0.0 was "hanging" in the groovy-linter.
Seems fine with 6.6.0

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of suggestions which I'd prefer to see addressed if possible, but since it's close to the end of my day I don't want to block this from being merged when there is the potential for a relevant tag to come out, so I'll give it my approval.

It mostly looks ok to me, but but I haven't done an exhaustive review so the proof of whether it does the trick will be when it runs ;-)

Noting that there is probably some doc that needs updating based on all the changes from this new process.

tools/nightly_build_and_test_stats.groovy Outdated Show resolved Hide resolved
tools/nightly_build_and_test_stats.groovy Outdated Show resolved Hide resolved
@andrew-m-leonard
Copy link
Contributor Author

andrew-m-leonard commented Jun 20, 2024

Noting that there is probably some doc that needs updating based on all the changes from this new process.

yep, already updated: https://github.com/adoptium/temurin-build/wiki/Setting-up-new-build-jobs,-mirrors,...-when-a-new-openjdk-version-is-branched-from-jdk(head)

@andrew-m-leonard andrew-m-leonard merged commit f0af2f2 into adoptium:master Jun 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-tools Issues that are miscellaneous enhancements or bugs with our utilities that assist our build scripts ghActions jenkins-pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EA trigger and daily Slack updates to build and report jdk(head) version branches, eg.jdk23
3 participants