Ensure any old openjdk build directory is removed before building

[andrew-m-leonard]

The openjdk build output directory may exist from a previous build if it was aborted or purposely kept.
It must always be deleted prior to a new build.

[github-actions]

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

[andrew-m-leonard]

run tests

[steelhead31]

LGTM

[sophia-guo]

Does the code https://github.com/adoptium/ci-jenkins-pipelines/blob/master/pipelines/build/common/openjdk_build_pipeline.groovy#L1792-L1817 do the clean?

[eclipse-temurin-bot]

 PR TESTER RESULT 

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

[sophia-guo]

Wondered if this should be done in temurin-build?

[andrew-m-leonard]

Does the code https://github.com/adoptium/ci-jenkins-pipelines/blob/master/pipelines/build/common/openjdk_build_pipeline.groovy#L1792-L1817 do the clean?

yes, this line:
context.sh(script: 'rm -rf ' + context.WORKSPACE + '/*')
openjdk_build dir is under WORKSPACE

[andrew-m-leonard]

Wondered if this should be done in temurin-build?

So no, because a user may have specified a user openjdk build folder that maybe by accident is some location they don't want to delete like /home !

[andrew-m-leonard]

run tests

[andrew-m-leonard]

Aborted Windows build jobs are always going to be an issue, as kill -9 on Windows processes can cause "locked" files, so I warn against aborting Windows jobs if possible

[eclipse-temurin-bot]

 PR TESTER RESULT 

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

[sophia-guo]

If cleanWorkspace=true context.WORKSPACE will be cleaned up include openjdk_build_dir(under WORKSPACE). Otherwise openjdk_build_dir will not be cleaned up.

This pr will cleanup openjdk_build_dir(under WORKSPACE) even if cleanWorkspace=false. However any other files or directory under the WORKSPACE will not be cleaned up if cleanWorkspace=false.

Just curious any reason we don't do the cleanWorkspace by default CLEAN_WORKSPACE": false?

[andrew-m-leonard]

If cleanWorkspace=true context.WORKSPACE will be cleaned up include openjdk_build_dir(under WORKSPACE). Otherwise openjdk_build_dir will not be cleaned up.

This pr will cleanup openjdk_build_dir(under WORKSPACE) even if cleanWorkspace=false. However any other files or directory under the WORKSPACE will not be cleaned up if cleanWorkspace=false.

Just curious any reason we don't do the cleanWorkspace by default CLEAN_WORKSPACE": false?

We have always not cleaned the WORKSPACE before a build by default for nightly/weekly builds, the reason is to save time in having to re-clone the openjdk src repository(~2Gb) each time.
Release builds do clean WORKSPACE before a build.