Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark node offline if cannot delete workspace #5374

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Mark node offline if cannot delete workspace #5374

merged 1 commit into from
Jun 12, 2024

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Jun 7, 2024

related: #5358

@llxia llxia requested review from pshipton and LongyuZhang June 7, 2024 18:43
LongyuZhang
LongyuZhang approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karianna karianna merged commit e78e183 into adoptium:master Jun 12, 2024
2 checks passed
@pshipton
Copy link
Contributor

Seems this has tanked all the OpenJ9 testing. Every test run is failing with the following.

Example https://openj9-jenkins.osuosl.org/job/Test_openjdk11_j9_sanity.functional_ppc64_aix_OMR_testList_0/559/

org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
WorkflowScript: 502: unexpected char: '\' @ line 502, column 70.
   ROR: Cannot delete workspace :\s?Unable

pshipton added a commit that referenced this pull request Jun 13, 2024
@pshipton
Revert "Mark node offline if cannot delete workspace (#5374)"
c076fcb 
This reverts commit e78e183.
@pshipton pshipton mentioned this pull request Jun 13, 2024
Merged
@pshipton
Copy link
Contributor

Created a revert PR #5386

@knn-k knn-k mentioned this pull request Jun 13, 2024
Closed
JasonFengJ9 pushed a commit that referenced this pull request Jun 13, 2024
@pshipton
Revert "Mark node offline if cannot delete workspace (#5374)" (#5386)
3dba824 
This reverts commit e78e183.
@sxa sxa mentioned this pull request Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LongyuZhang LongyuZhang LongyuZhang approved these changes

@karianna karianna karianna approved these changes

@pshipton pshipton Awaiting requested review from pshipton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@llxia @pshipton @karianna @LongyuZhang