Stop running jdk_vector testing on OpenJ9 jdk17 #5365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llxia
reviewed
Jun 3, 2024
openjdk/playlist.xml
Outdated
| </impls> | ||
| </test> | ||
| <test> | ||
| <testCaseName>jdk_vector_j9</testCaseName> |
There was a problem hiding this comment.
Instead of adding a new jdk_vector_j9, we can add disable in jdk_vector
<disables>
<disable>
<comment>issue link</comment>
<impl>openj9</impl>
<version>17</version>
</disable>
</disables>
pshipton
force-pushed
the
vector17
branch
2 times, most recently
from
79f9eeb to
c77ce10
Compare
llxia
reviewed
Jun 3, 2024
| <impl>ibm</impl> | ||
| <version>17</version> | ||
| </disable> | ||
| </disables> |
There was a problem hiding this comment.
Unfortunately, we cannot have 2 impl in one <disable>. They have to be separated.
<disables>
<disable>
<comment>https://github.com/eclipse-openj9/openj9/issues/19360</comment>
<impl>openj9</impl>
<version>17</version>
</disable>
<disable>
<comment>https://github.com/eclipse-openj9/openj9/issues/19360</comment>
<impl>ibm</impl>
<version>17</version>
</disable>
</disables>
vector is an incubator and by design there is no JIT support for jdk17 any more, resulting in test timeouts. Issue eclipse-openj9/openj9#19360 Signed-off-by: Peter Shipton <[email protected]>
JasonFengJ9
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vector is an incubator and by design there is no JIT support for jdk17 any more, resulting in test timeouts.
Issue eclipse-openj9/openj9#19360