Added new MockitoTests SegmentationErrorTest #5133

sophiaxu0424 · 2024-03-11T17:39:08Z

Related issue: Add a Mockito Testcase #5073
Grinder build passed:
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/39630/console

LongyuZhang

Binary files should not be put in the PR.

karianna

remove .class files

llxia · 2024-03-11T23:09:38Z

All the tests are disabled. The above Grinder did not test anything.

llxia

please remove pom.xml as we do not run maven
ideally, we only need one folder, not multiple ones. Please only include required java files under one src folder.
I am not sure maven_jar_plugin in Add build dependencies for Mockito testcase TKG#505 is needed
I do not see any testNG API being used in java file. I am not sure the purpose of using testNG in this case.
Test the PR in Grinder to ensure the test runs and passes with latest SDK, and fails with the old SDK (without fix)

llxia · 2024-03-11T23:31:53Z

Ideally, the folder structure should look like the following. We should not need anything extra.

MockitoTests
- src
  - java package/ java file
- build.xml
- playlist.xml

smlambert · 2024-03-11T23:45:34Z

It may also be useful to add a short README file in functional/MockitoTests directory, especially if the intention will be to add more Mockito-based testing into it (to give guidance on how to do so) or to say what the current test target is intended to test.

karianna

Code looks broadly OK but will leave to the experts to make a call on this one.

llxia · 2024-03-16T03:35:10Z

Move this back to draft until the above comments are addressed.

fix Signed-off-by: sophiaxu0424 <[email protected]>

Signed-off-by: sophiaxu0424 <[email protected]>

karianna

Change looks broadly OK to me but would prefer two other reviewers closer to aqa-tests to review

functional/MockitoTests/playlist.xml

functional/MockitoTests/src/test/java/MockitoMockTest.java

Signed-off-by: sophiaxu0424 <[email protected]>

sophiaxu0424 · 2024-04-11T13:08:38Z

Since JDK11 passes, please check with dev if we should enable the test on JDK11.

Please run Grinder on wins. If this test applies to zOS, please also run Grinder. Thanks

Dev team has agreed to use 11

Tested on windows and zlinux
On s390x_linux customed sdk 17
Passed: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/39661/console

On windows- customed openj9 sdk 17
Passed: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/39668/

llxia · 2024-04-12T13:29:08Z

@sophiaxu0424 are you going to test on zOS? And we need also run test against hotspot.

functional/MockitoTests/src/test/java/MockitoMockTest.java

sophiaxu0424 · 2024-04-12T14:24:10Z

@sophiaxu0424 are you going to test on zOS? And we need also run test against hotspot.

Hi Lan,

On IBM ZOS platform - customed ibm idk 17
Failed: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/39771/consoleFull

Signed-off-by: sophiaxu0424 <[email protected]>

llxia · 2024-04-12T14:31:35Z

Please analyze the failure to ensure it is not a test setup issue. If everything is ok, then confirm with the dev team if the behavior is expected or not.

sophiaxu0424 · 2024-04-12T15:58:41Z

Please analyze the failure to ensure it is not a test setup issue. If everything is ok, then confirm with the dev team if the behavior is expected or not.

Hi Lan, it is not an test setup failure, after talking with Babneet, and he suggested that we can exclude this test on ZOS and document it.

llxia · 2024-04-16T19:20:43Z

we can exclude this test on ZOS

Please update the PR to exclude the test on zOS.

sophiaxu0424 · 2024-04-17T11:51:31Z

@sophiaxu0424 are you going to test on zOS? And we need also run test against hotspot.

Hi Lan, build run on hotspot:
hotspot x86_linux java 17
Passed: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/39885/

llxia · 2024-04-17T12:38:57Z

functional/MockitoTests/playlist.xml

+				<comment>Temporarily disabled on z/OS for now</comment>
+				<platform>.*zos.*</platform>
+				<impl>ibm</impl>
+				<version>11+</version>


Please remove <version>11+</version> and <impl>ibm</impl>

llxia · 2024-04-17T12:40:07Z

For due diligence, please run the test against 11 and 21 hotspot.

Signed-off-by: sophiaxu0424 <[email protected]>

llxia · 2024-04-17T13:00:40Z

functional/MockitoTests/playlist.xml

+		<testCaseName>MockitoMockTest</testCaseName>
+		<disables>
+			<disable>
+				<comment>Temporarily disabled on z/OS for now</comment>


Do we have an issue for this?

No, and it passed/disabled: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/39895/

Please ask the dev team for the issue. Otherwise, we have no way to track this temporary disable.

Asked Babneet, and he suggested me to open one issue under openj9/issue, and here's the link, I've added this info to our disable comment.
eclipse-openj9/openj9#19331

sophiaxu0424 · 2024-04-17T13:22:52Z

For due diligence, please run the test against 11 and 21 hotspot.
hotspot 11 passed: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/39896/rebuild/parameterized
hotspot 21 passed: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/39897/rebuild/parameterized

Signed-off-by: sophiaxu0424 <[email protected]>

functional/MockitoTests/playlist.xml

Signed-off-by: sophiaxu0424 <[email protected]>

llxia

LGTM

llxia · 2024-04-18T12:58:57Z

Since this PR is only one of the two tests, @sophiaxu0424 please change Fix issue: https://github.com/adoptium/aqa-tests/issues/5073 to related in the description.

llxia · 2024-04-18T13:12:15Z

Note:

need to merge with Added dependencies for MockitoTest case TKG#526
test.getDependency job in all 3 Jenkins (i.e., https://openj9-jenkins.osuosl.org/job/test.getDependency/) should be launched after the Added dependencies for MockitoTest case TKG#526 is merged.

LongyuZhang

LGTM

sophiaxu0424 force-pushed the issue5073 branch 3 times, most recently from d3ba8dc to ab2044f Compare March 11, 2024 20:57

sophiaxu0424 marked this pull request as ready for review March 11, 2024 21:31

LongyuZhang reviewed Mar 11, 2024

View reviewed changes

karianna requested changes Mar 11, 2024

View reviewed changes

llxia requested changes Mar 11, 2024

View reviewed changes

sophiaxu0424 force-pushed the issue5073 branch 2 times, most recently from 964f833 to 0e72efa Compare March 12, 2024 02:58

karianna requested review from llxia and LongyuZhang March 12, 2024 06:24

karianna reviewed Mar 12, 2024

View reviewed changes

llxia marked this pull request as draft March 16, 2024 03:35

sophiaxu0424 added 13 commits March 20, 2024 14:20

$Signed-off-by: sophiaxu0424 <[email protected]>

fdc7ab8

fix Signed-off-by: sophiaxu0424 <[email protected]>

fif

f1fc7cf

Signed-off-by: sophiaxu0424 <[email protected]>

fix

4f459ed

Signed-off-by: sophiaxu0424 <[email protected]>

fix testng

f8b0793

Signed-off-by: sophiaxu0424 <[email protected]>

fix

099f4d0

Signed-off-by: sophiaxu0424 <[email protected]>

fix

00792b1

Signed-off-by: sophiaxu0424 <[email protected]>

fixx

37403ed

Signed-off-by: sophiaxu0424 <[email protected]>

add command element

11cd5b1

Signed-off-by: sophiaxu0424 <[email protected]>

added command part

b6d54ae

Signed-off-by: sophiaxu0424 <[email protected]>

fix command

727a49d

Signed-off-by: sophiaxu0424 <[email protected]>

added junit-platform-console-standalone.jar

902d696

Signed-off-by: sophiaxu0424 <[email protected]>

fix

6148f3d

Signed-off-by: sophiaxu0424 <[email protected]>

fix

e9aa17e

Signed-off-by: sophiaxu0424 <[email protected]>

karianna self-requested a review April 10, 2024 20:28

karianna reviewed Apr 10, 2024

View reviewed changes

LongyuZhang reviewed Apr 11, 2024

View reviewed changes

functional/MockitoTests/playlist.xml Outdated Show resolved Hide resolved

functional/MockitoTests/src/test/java/MockitoMockTest.java Outdated Show resolved Hide resolved

fixed as to the review comment

081f198

Signed-off-by: sophiaxu0424 <[email protected]>

sophiaxu0424 force-pushed the issue5073 branch from c2108ae to 081f198 Compare April 11, 2024 13:07

llxia reviewed Apr 12, 2024

View reviewed changes

functional/MockitoTests/src/test/java/MockitoMockTest.java Show resolved Hide resolved

added license info

8f797e3

Signed-off-by: sophiaxu0424 <[email protected]>

karianna approved these changes Apr 14, 2024

View reviewed changes

llxia reviewed Apr 17, 2024

View reviewed changes

disabled test on zos platform

e649563

Signed-off-by: sophiaxu0424 <[email protected]>

sophiaxu0424 force-pushed the issue5073 branch from c84b469 to e649563 Compare April 17, 2024 12:59

llxia reviewed Apr 17, 2024

View reviewed changes

Added tracking issue

893cbc4

Signed-off-by: sophiaxu0424 <[email protected]>

llxia reviewed Apr 17, 2024

View reviewed changes

functional/MockitoTests/playlist.xml Outdated Show resolved Hide resolved

updated the comment

0534ec2

Signed-off-by: sophiaxu0424 <[email protected]>

llxia approved these changes Apr 18, 2024

View reviewed changes

LongyuZhang approved these changes Apr 18, 2024

View reviewed changes

LongyuZhang merged commit 78002b9 into adoptium:master Apr 18, 2024
2 checks passed

babsingh mentioned this pull request May 14, 2024

MockitoMockTest doesn't run on jdk23 yet - Java 23 (67) is not supported by the current version of Byte Buddy eclipse-openj9/openj9#19354

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added new MockitoTests SegmentationErrorTest #5133

Added new MockitoTests SegmentationErrorTest #5133

sophiaxu0424 commented Mar 11, 2024 •

edited

Loading

LongyuZhang left a comment

karianna left a comment

llxia commented Mar 11, 2024

llxia left a comment •

edited

Loading

llxia commented Mar 11, 2024

smlambert commented Mar 11, 2024

karianna left a comment

llxia commented Mar 16, 2024

karianna left a comment •

edited

Loading

sophiaxu0424 commented Apr 11, 2024 •

edited

Loading

llxia commented Apr 12, 2024 •

edited

Loading

sophiaxu0424 commented Apr 12, 2024 •

edited

Loading

llxia commented Apr 12, 2024

sophiaxu0424 commented Apr 12, 2024 •

edited

Loading

llxia commented Apr 16, 2024

sophiaxu0424 commented Apr 17, 2024

llxia Apr 17, 2024

llxia commented Apr 17, 2024

llxia Apr 17, 2024

sophiaxu0424 Apr 17, 2024

llxia Apr 17, 2024

sophiaxu0424 Apr 17, 2024

sophiaxu0424 commented Apr 17, 2024

llxia left a comment

llxia commented Apr 18, 2024

llxia commented Apr 18, 2024

LongyuZhang left a comment

Added new MockitoTests SegmentationErrorTest #5133

Added new MockitoTests SegmentationErrorTest #5133

Conversation

sophiaxu0424 commented Mar 11, 2024 • edited Loading

LongyuZhang left a comment

Choose a reason for hiding this comment

karianna left a comment

Choose a reason for hiding this comment

llxia commented Mar 11, 2024

llxia left a comment • edited Loading

Choose a reason for hiding this comment

llxia commented Mar 11, 2024

smlambert commented Mar 11, 2024

karianna left a comment

Choose a reason for hiding this comment

llxia commented Mar 16, 2024

karianna left a comment • edited Loading

Choose a reason for hiding this comment

sophiaxu0424 commented Apr 11, 2024 • edited Loading

llxia commented Apr 12, 2024 • edited Loading

sophiaxu0424 commented Apr 12, 2024 • edited Loading

llxia commented Apr 12, 2024

sophiaxu0424 commented Apr 12, 2024 • edited Loading

llxia commented Apr 16, 2024

sophiaxu0424 commented Apr 17, 2024

llxia Apr 17, 2024

Choose a reason for hiding this comment

llxia commented Apr 17, 2024

llxia Apr 17, 2024

Choose a reason for hiding this comment

sophiaxu0424 Apr 17, 2024

Choose a reason for hiding this comment

llxia Apr 17, 2024

Choose a reason for hiding this comment

sophiaxu0424 Apr 17, 2024

Choose a reason for hiding this comment

sophiaxu0424 commented Apr 17, 2024

llxia left a comment

Choose a reason for hiding this comment

llxia commented Apr 18, 2024

llxia commented Apr 18, 2024

LongyuZhang left a comment

Choose a reason for hiding this comment

sophiaxu0424 commented Mar 11, 2024 •

edited

Loading

llxia left a comment •

edited

Loading

karianna left a comment •

edited

Loading

sophiaxu0424 commented Apr 11, 2024 •

edited

Loading

llxia commented Apr 12, 2024 •

edited

Loading

sophiaxu0424 commented Apr 12, 2024 •

edited

Loading

sophiaxu0424 commented Apr 12, 2024 •

edited

Loading