Use jtreg6.1 for JDK11/17 on z/OS #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pasam Soujanya <[email protected]>
|
Verified the changes on JDK11 and JDK17 z/OS and multi-platform JDK11 non-z/OS Grinder_CR/27446 JDK11 on z/OS Grinder_CR/27464 JDK17 on non-z/OS Grinder_CR/27466/ JDK17 on z/OS Grinder_CR/27467 |
|
@llxia Could you please review these changes. Thank you. |
llxia
reviewed
Dec 2, 2024
scripts/getDependencies.xml
Outdated
| <if> | ||
| <!-- versions 8-10, 12-16 --> | ||
| <matches pattern="^([89]|1[02-6])$" string="${JDK_VERSION}"/> | ||
| <then> | ||
| <property name="jtregTar" value="jtreg_5_1_b01"/> | ||
| </then> | ||
| <elseif> | ||
| <!-- versions 11, 17 on z/OS --> |
There was a problem hiding this comment.
Could you please add the reason for using jtreg 6.1 for zOS and related issue in the comment?
There was a problem hiding this comment.
I've added justification for the change. Could you please review. Thank you.
karianna
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR to make JDK11 and JDK17 openjdk tests to use jtreg6.1 on z/OS. jtreg7.* has encoding issues on z/OS which led to Malformed Input Error with JDK11 and JDK17 on z/OS.