-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use jtreg6.1 for JDK11/17 on z/OS #645
Conversation
Signed-off-by: Pasam Soujanya <[email protected]>
Verified the changes on JDK11 and JDK17 z/OS and multi-platform JDK11 non-z/OS
Grinder_CR/27446 JDK11 on z/OS
Grinder_CR/27464 JDK17 on non-z/OS
Grinder_CR/27466/ JDK17 on z/OS
Grinder_CR/27467 |
@llxia Could you please review these changes. Thank you. |
scripts/getDependencies.xml
Outdated
<if> | ||
<!-- versions 8-10, 12-16 --> | ||
<matches pattern="^([89]|1[02-6])$" string="${JDK_VERSION}"/> | ||
<then> | ||
<property name="jtregTar" value="jtreg_5_1_b01"/> | ||
</then> | ||
<elseif> | ||
<!-- versions 11, 17 on z/OS --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add the reason for using jtreg 6.1 for zOS and related issue in the comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added justification for the change. Could you please review. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Testing now just fails:
Please help me understand how trying to use 6.1 on z/OS make sense. |
@keithc-ca This error is coming from JDK repos of 11 and 17. We've raised PRs there to use jtreg6.1. Once, these PRs are merged auto jobs should execute fine. |
This PR to make JDK11 and JDK17 openjdk tests to use jtreg6.1 on z/OS. jtreg7.* has encoding issues on z/OS which led to Malformed Input Error with JDK11 and JDK17 on z/OS.