-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable delete_branch_on_merge for AQA test repos #72
Conversation
resolves: adoptium/aqa-tests#5776 Signed-off-by: Lan Xia <[email protected]>
This is your friendly self-service bot. Thank you for raising a pull request to update the configuration of your GitHub organization. The following conditions need to fulfilled for auto-merging to be available:
Otterdog commands and optionsYou can trigger otterdog actions by commenting on this PR:
|
This comment has been minimized.
This comment has been minimized.
This is your friendly self-service bot. The current configuration is in-sync with the live settings. 🚀 |
This is your friendly self-service bot.
In order to automatically merge and apply the changes, add a comment |
Signed-off-by: Thomas Neidhart <[email protected]>
This is your friendly self-service bot. Diff for 881cc21Project adoptium[github_id=adoptium]
there have been 4 validation infos, enable verbose output to display them.
! repository[name="STF"] {
! delete_branch_on_merge = false -> true
! }
! repository[name="TKG"] {
! delete_branch_on_merge = false -> true
! }
! repository[name="aqa-systemtest"] {
! delete_branch_on_merge = false -> true
! }
! repository[name="aqa-test-tools"] {
! delete_branch_on_merge = false -> true
! }
! repository[name="aqa-tests"] {
! delete_branch_on_merge = false -> true
! }
! repository[name="openj9-systemtest"] {
! delete_branch_on_merge = false -> true
! }
Plan: 0 to add, 6 to change, 0 to delete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @llxia !
Apparently I have either lost write access or never had write permissions to this repo so can not merge this. @netomi - Who should have write access to this repo? Adoptium PMC members? Or is it restricted? I see https://github.com/orgs/adoptium/teams/eclipsefdn-security and also expect project security teams should have permissions for updating this configuration. |
|
/otterdog merge |
This is your friendly self-service bot. The following changes have been successfully applied: Project adoptium[github_id=adoptium]
there have been 4 validation infos, enable verbose output to display them.
! repository[name="STF"] {
! delete_branch_on_merge = false -> true
! }
! repository[name="TKG"] {
! delete_branch_on_merge = false -> true
! }
! repository[name="aqa-systemtest"] {
! delete_branch_on_merge = false -> true
! }
! repository[name="aqa-test-tools"] {
! delete_branch_on_merge = false -> true
! }
! repository[name="aqa-tests"] {
! delete_branch_on_merge = false -> true
! }
! repository[name="openj9-systemtest"] {
! delete_branch_on_merge = false -> true
! }
Applying changes:
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00
Done.
Executed plan: 0 added, 6 changed, 0 deleted. |
thanks @netomi - the more words and help I am offered by bots, the less likely I am to read them... :) appreciate your patient guidance! |
it becomes repetitive after some time, maybe if an org had already more than x number of PRs, only let the bot say the minimum required stuff. |
resolves: adoptium/aqa-tests#5776