Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lt-body): scrollToRow before render #729

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FalkF
Copy link

@FalkF FalkF commented Mar 25, 2020

When changing the scrollToRow before newly added rows are rendered targetScrollOffset can not be calculated:

this.table.addRows(data);
const targetRow = this.table.rows.find(element => element.get('name') === 'target');
set(this, 'scrollToRow', targetRow);

This can be worked around by changing scrollToRow in the next runloop, but it would be cool to just make it work.

@FalkF FalkF force-pushed the fix-scrollToRow-bug branch from eb22dfb to 9fe8f78 Compare March 25, 2020 19:20
@RobbieTheWagner
Copy link
Member

@FalkF Thanks for the PR! We've recently made a lot of significant changes to ember-light-table. Can you please rebase your PR and make sure everything is still working as intended? If this PR is no longer necessary after the new changes, please close it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants