Skip to content

Commit

Permalink
chore(ci/ember-try): add useYarn
Browse files Browse the repository at this point in the history 
This should yield faster builds.

https://github.com/ember-cli/ember-try#yarn
  • Loading branch information
@buschtoens
buschtoens committed Dec 19, 2017
1 parent 0d99b0f commit e480895
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions config/ember-try.js
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/* eslint-env node */
module.exports = {
useVersionCompatibility: true,
useYarn: true,
scenarios: [
{
name: 'ember-lts-2.4',
Expand Down

5 comments on commit e480895

@alexander-alvarez
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is https://github.com/offirgolan/ember-light-table/blob/a428ac928a0d8564e27de47d8dbab20b6d8bdeea/.travis.yml#L39 still needed?

@buschtoens
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. The line in travis.yml installs ember-cli and ember-try as well as all other addons themselves, while useYarn causes ember-try to use yarn while installing a specific scenario, as defined in the config.

@alexander-alvarez
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it..

What about the scenarios being defined with ember being pulled from bower, could that be changed?
I'm about to kill bower in our app and I will need to update our config too, so was reviewing here for reference and there two jumped out at me.

@buschtoens
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, no. ember-source is only being published to npm since 2.10.0-alpha.1.

But does that matter in the context of your app? Are you testing against multiple Ember versions? 🤔

@alexander-alvarez
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to know.. thanks 😄

Are you testing against multiple Ember versions

we test against later versions that we haven't upgraded to yet, so we know if we need to fix up any of our code / update an addon before getting to that actual Ember version

Please sign in to comment.