Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added hmset to ioMethods.ts #58

Merged
merged 3 commits into from
Sep 14, 2023
Merged

added hmset to ioMethods.ts #58

merged 3 commits into from
Sep 14, 2023

Conversation

isimisi
Copy link
Contributor

@isimisi isimisi commented Sep 12, 2023

Proposed changes

I'm was trying to test something and ran the following command:

import { BaseCommand } from "@adonisjs/core/build/standalone";
export default class TestCommand extends BaseCommand {
  /**
   * Command name is used to run the command
   */
  public static commandName = "test:command";

  /**
   * Command description is displayed in the "help" output
   */
  public static description = "";

  public static settings = {
    /**
     * Set the following value to true, if you want to load the application
     * before running the command. Don't forget to call `node ace generate:manifest`
     * afterwards.
     */
    loadApp: true,

    /**
     * Set the following value to true, if you want this command to keep running until
     * you manually decide to exit the process. Don't forget to call
     * `node ace generate:manifest` afterwards.
     */
    stayAlive: false,
  };

  public async run() {
    const { default: Redis } = await import("@ioc:Adonis/Addons/Redis");

    // TS tells me that Redis.hmset exists and everything is typed 
    const result = await Redis.hmset("test:123456:test", { a: "a", b: "b" });

    console.log(result);
  }
}

I get the following error:

  TypeError: Redis.hmset is not a function

   at TestThing.run /Users/u/Documents/GitHub/API/commands/TestCommand.ts:32
   27|    };
   28|
   29|    public async run() {
   30|      const { default: Redis } = await import("@ioc:Adonis/Addons/Redis");
   31|
 ❯ 32|      const result = await Redis.hmset("test:123456:test", { a: "a", b: "b" });
   33|
   34|      console.log(result);
   35|    }
   36|  }

Response from @Julien-R44

hey, can you add your method here and make a PR?
https://github.com/adonisjs/redis/blob/develop/src/ioMethods.ts
I'll do a release once merged

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@Julien-R44 Julien-R44 merged commit c80075a into adonisjs:develop Sep 14, 2023
2 checks passed
@Julien-R44
Copy link
Member

Thankss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants