Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(QueryBuilder/where): add null type to where clause #967

Merged
merged 1 commit into from
Nov 20, 2023
Merged

feat(QueryBuilder/where): add null type to where clause #967

merged 1 commit into from
Nov 20, 2023

Conversation

MaximeMRF
Copy link
Contributor

Proposed changes

Referred to the issue #952 this PR allow to get informations in the db that is marked as null and don't get type error

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@RomainLanz RomainLanz closed this Nov 16, 2023
@RomainLanz RomainLanz reopened this Nov 16, 2023
@thetutlage thetutlage merged commit 2790fe9 into adonisjs:develop Nov 20, 2023
21 of 22 checks passed
@thetutlage
Copy link
Member

Looks good! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaximeMRF @thetutlage @RomainLanz