Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced Promise.all with for loop #1028

Closed
wants to merge 1 commit into from

Conversation

mdsadiqueinam
Copy link
Contributor

@mdsadiqueinam mdsadiqueinam commented May 11, 2024

the Promise.all creates the deadlock causing the command db:truncate to throw error deadlock detected

πŸ”— Linked issue

#1027

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Replaced Promise.all with for loop in db_truncate.ts resolves #1027

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

the `Promise.all` creates the  deadlock causing the command `db:truncate` to throw error deadlock detected
@thetutlage
Copy link
Member

Please first share a reproduction of what exactly the issue is. We cannot change code that is been working for years for everyone.

@thetutlage thetutlage closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node ace db:truncate throws the error deadlock detected
2 participants