-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unique accept options as object #1012
Conversation
Hey, both Also let's add some tests for the new implementation.
Haha, seems like it never got documented. So we will have to document it from scratch. |
It use overload now. I'm not sure how to get started to write test for a binding and for as much as I looked, I cannot use previous test to get inspiration because they do not exist (or I can't find it). Where do you think we should document it? On the Lucid doc with a |
Hello, will it be merged soon? I have two questions:
I can open another PR if you want. |
Sorry slept on the PR for quite long as did not have the energy to manage multiple things. I will merge this PR and then do other improvements like adding |
Improved both the validations. 761f823 |
π Linked issue
#995
β Type of change
π Description
Current
unique
rule becomesuniqueRaw
as proposed by @thetutlage on #995 and we add a newunique
allowing a simpler and more expressive API inspired from Adonis v5.Feel free to comment the implem, I'm not fully familiar with Adonis codebase. I couldn't found the doc about future old
unique
rule, can you show me where it's mentionned in the doc so I can update the doc?π Checklist