Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(argon): #variants to rely on argon2 exports #17

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

austinfelipe
Copy link
Contributor

@austinfelipe austinfelipe commented Nov 13, 2024

πŸ”— Linked issue

#16

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Changes:

  • update argon.ts to rely on argon2 exports to define variants values
  • add tests to cover each individual variant
  • update test comment to reflect the correct value

Why:

Currently, variants don't match argon2 lib, so when trying to verify i or d, it will fail.

Resolves #16

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@thetutlage
Copy link
Member

Looks good. Thanks for fixing it πŸ‘

@thetutlage thetutlage merged commit 667171f into adonisjs:9.x Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot verify Argon variant i and d
2 participants