-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release] Stage to Main #3512
[Release] Stage to Main #3512
Conversation
…3424) * authorable solution * Updated copy for progress bar * code optimization * unit tests * eslint * milolibs fix * milolibs fix * Restructured the code and followed review comments * bug fix - mwpw-164933 * bug fix - mwpw-164933 * bug fix - mwpw-164933 * bug fix - mwpw-164933 * bug fix - mwpw-164933 * bug fix - mwpw-164933 * bug fix - mwpw-164933 * bug fix - mwpw-164933 * bug fix - mwpw-164933 * code review * ecid * Removed circle loader as it is not required * shortened variable names * moved css to branch-quick-links.css * cleaned css * changed authoring * Handled loader delay * Reverting UTs * modified UTs * UT fix * Unit tests * review changes --------- Co-authored-by: Drashti Modasara <[email protected]> Co-authored-by: Drashti Modasara <[email protected]> Co-authored-by: Drashti Modasara <[email protected]>
resolve conflicts with refactored code
ENB-7642: Remove console errors and update test cases
Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot |
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3512 +/- ##
==========================================
- Coverage 96.47% 96.47% -0.01%
==========================================
Files 258 260 +2
Lines 60150 60415 +265
==========================================
+ Hits 58029 58284 +255
- Misses 2121 2131 +10 ☔ View full report in Codecov by Sentry. |
* Hamburger icon issue fix * Hamburger icon issue fix * Hamburger icon issue fix * app banner with level 2 screen issue fix as primary cta not visible * app banner with level 2 screen issue fix as primary cta not visible * Header with navPromo top should be for all viewports * [MWPW-165142] Bug Fix * Add UT
* Don't merge PRs with running tests * Adapt check to disregard skipped checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored by default. Use a negated ignore pattern (like "--ignore-pattern '!<relative/path/to/filename>'") to override.
hello @JackySun9 @hadobe @Dli3 @Roycethan im holding this PR until tomorrow IST 2.45 as some Gnav changes from PR should go as planned release during IST on 22ed. you folks please verify and give approval from your end. thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will provide approval during 22ed IST to release some changes part of Gnav release. thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sonawanesnehal3 ,
We're seeing a regression issue on bacom. The region picker no longer has the attribute "aria-haspopup".
Test pages:
main: https://business.stage.adobe.com/?martech=off#langnav
stage: https://business.stage.adobe.com/?milolibs=stage&martech=off#langnav
Hi @Dli3 , |
common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo: