Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #3512

Merged
merged 8 commits into from
Jan 23, 2025
Merged

[Release] Stage to Main #3512

merged 8 commits into from
Jan 23, 2025

Conversation

drashti1712 and others added 3 commits January 20, 2025 09:25
…3424)

* authorable solution

* Updated copy for progress bar

* code optimization

* unit tests

* eslint

* milolibs fix

* milolibs fix

* Restructured the code and followed review comments

* bug fix - mwpw-164933

* bug fix - mwpw-164933

* bug fix - mwpw-164933

* bug fix - mwpw-164933

* bug fix - mwpw-164933

* bug fix - mwpw-164933

* bug fix - mwpw-164933

* bug fix - mwpw-164933

* bug fix - mwpw-164933

* code review

* ecid

* Removed circle loader as it is not required

* shortened variable names

* moved css to branch-quick-links.css

* cleaned css

* changed authoring

* Handled loader delay

* Reverting UTs

* modified UTs

* UT fix

* Unit tests

* review changes

---------

Co-authored-by: Drashti Modasara <[email protected]>
Co-authored-by: Drashti Modasara <[email protected]>
Co-authored-by: Drashti Modasara <[email protected]>
resolve conflicts with refactored code
ENB-7642: Remove console errors and update test cases
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Jan 20, 2025

Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot

Copy link
Contributor

aem-code-sync bot commented Jan 20, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jan 20, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 93.60269% with 19 lines in your changes missing coverage. Please review.

Project coverage is 96.47%. Comparing base (6eb0401) to head (a4101ed).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
libs/blocks/rollout/rollout.js 92.03% 16 Missing ⚠️
.../features/branch-quick-links/branch-quick-links.js 96.05% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3512      +/-   ##
==========================================
- Coverage   96.47%   96.47%   -0.01%     
==========================================
  Files         258      260       +2     
  Lines       60150    60415     +265     
==========================================
+ Hits        58029    58284     +255     
- Misses       2121     2131      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Hamburger icon issue fix

* Hamburger icon issue fix

* Hamburger icon issue fix

* app banner with level 2 screen issue fix as primary cta not visible

* app banner with level 2 screen issue fix as primary cta not visible

* Header with navPromo top should be for all viewports

* [MWPW-165142] Bug Fix

* Add UT
* Don't merge PRs with running tests

* Adapt check to disregard skipped checks
@aem-code-sync aem-code-sync bot temporarily deployed to stage January 20, 2025 10:47 Inactive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored by default. Use a negated ignore pattern (like "--ignore-pattern '!<relative/path/to/filename>'") to override.

@sigadamvenkata
Copy link

hello @JackySun9 @hadobe @Dli3 @Roycethan im holding this PR until tomorrow IST 2.45 as some Gnav changes from PR should go as planned release during IST on 22ed. you folks please verify and give approval from your end. thanks

Copy link

@sigadamvenkata sigadamvenkata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will provide approval during 22ed IST to release some changes part of Gnav release. thanks

Copy link

@Dli3 Dli3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sonawanesnehal3 ,
We're seeing a regression issue on bacom. The region picker no longer has the attribute "aria-haspopup".
Screenshot 2025-01-21 at 1 35 58 PM

Test pages:
main: https://business.stage.adobe.com/?martech=off#langnav
stage: https://business.stage.adobe.com/?milolibs=stage&martech=off#langnav

@sonawanesnehal3
Copy link
Contributor

Hi @sonawanesnehal3 , We're seeing a regression issue on bacom. The region picker no longer has the attribute "aria-haspopup". Screenshot 2025-01-21 at 1 35 58 PM

Test pages: main: https://business.stage.adobe.com/?martech=off#langnav stage: https://business.stage.adobe.com/?milolibs=stage&martech=off#langnav

Hi @Dli3 ,
Yes this is removed as part of https://jira.corp.adobe.com/browse/DOTCOM-128840. Because the screenreader was reading it incorrect. So to achieve expected behaviour "aria-haspopup" is removed for modal region picker. Details of expected behaviour can be found in jira comments.

@milo-pr-merge milo-pr-merge bot merged commit f3ab5ac into main Jan 23, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.