-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-146930 - Rollout tool plugin #3463
base: stage
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stage #3463 +/- ##
==========================================
- Coverage 96.46% 96.44% -0.02%
==========================================
Files 255 256 +1
Lines 59363 59621 +258
==========================================
+ Hits 57266 57504 +238
- Misses 2097 2117 +20 ☔ View full report in Codecov by Sentry. |
8bd8dbc
to
78763b9
Compare
78763b9
to
885509b
Compare
); | ||
|
||
const params = { | ||
milolibs: 'milostudio-stage', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Sabya,
Sorry for bringing this a little late.
You may need to set this value dynamically, as milolibs value change depending on env. We wanted to keep prod and stage code separate.
Prod:
milolibs = milostudio
stage and lower env:
milolibs= milostudio-stage
CC: @nkthakur48 , @raga-adbe-gh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sabyamon Could you please have a look at the comment provided by @saurabhsircar11
Adding option in sidekick to rollout files directly to geos. This plugin will do some basic calculation and form a url. On selection of the environment, the user will be taken to the Loc V3 project config page with some options (sent as part of the parameter) pre-selected.
Resolves: https://jira.corp.adobe.com/browse/MWPW-146930
Test URLs:
This feature can be tested in Milo and in BACOM by selecting the
Test project configuration locally
and providing the URLhttps://rollout-tool--milo--sabyamon.hlx.page