Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-146930 - Rollout tool plugin #3463

Open
wants to merge 6 commits into
base: stage
Choose a base branch
from

Conversation

sabyamon
Copy link
Contributor

Adding option in sidekick to rollout files directly to geos. This plugin will do some basic calculation and form a url. On selection of the environment, the user will be taken to the Loc V3 project config page with some options (sent as part of the parameter) pre-selected.

Resolves: https://jira.corp.adobe.com/browse/MWPW-146930

Test URLs:

This feature can be tested in Milo and in BACOM by selecting the Test project configuration locally and providing the URL https://rollout-tool--milo--sabyamon.hlx.page

Copy link
Contributor

aem-code-sync bot commented Jan 12, 2025

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@sabyamon sabyamon added the new-feature New block or other feature label Jan 12, 2025
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 92.03980% with 16 lines in your changes missing coverage. Please review.

Project coverage is 96.44%. Comparing base (82694a3) to head (3d78323).
Report is 38 commits behind head on stage.

Files with missing lines Patch % Lines
libs/blocks/rollout/rollout.js 92.03% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3463      +/-   ##
==========================================
- Coverage   96.46%   96.44%   -0.02%     
==========================================
  Files         255      256       +1     
  Lines       59363    59621     +258     
==========================================
+ Hits        57266    57504     +238     
- Misses       2097     2117      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

);

const params = {
milolibs: 'milostudio-stage',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sabya,
Sorry for bringing this a little late.
You may need to set this value dynamically, as milolibs value change depending on env. We wanted to keep prod and stage code separate.

Prod:
milolibs = milostudio

stage and lower env:
milolibs= milostudio-stage

CC: @nkthakur48 , @raga-adbe-gh

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sabyamon Could you please have a look at the comment provided by @saurabhsircar11

@nkthakur48 nkthakur48 requested a review from amitbikram January 20, 2025 14:53
@sigadamvenkata
Copy link

issue verified in branch, adding ready for stage label. PFA
image

@sigadamvenkata sigadamvenkata added verified PR has been E2E tested by a reviewer Ready for Stage labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature New block or other feature Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants