Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

48 announcement video #52

Merged
merged 5 commits into from
Mar 8, 2023
Merged

Conversation

cuzuco2
Copy link
Collaborator

@cuzuco2 cuzuco2 commented Mar 6, 2023

Description

This fixes the new feature that needs overlapping of animated gif in the first announcement page

Related Issue

This fixes #48

Motivation and Context

How Has This Been Tested?

You can test the end solution here:
https://48-announcement-video--adobe-io-website--adobe.hlx.page/photoshop/index-new

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@cuzuco2 cuzuco2 requested review from timkim and solaris007 March 6, 2023 16:30
@aem-code-sync
Copy link

aem-code-sync bot commented Mar 6, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Mar 6, 2023

Page Score PSI Audit Google
/photoshop/index-new SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Mar 7, 2023

Page Score PSI Audit Google
/photoshop/index-new SI FCP LCP TBT CLS PSI

@timkim timkim merged commit f0672d8 into stage-franklin-upgrades Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants