Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted media block #150

Open
wants to merge 1 commit into
base: fresh-spectrum
Choose a base branch
from
Open

Conversation

manimitrah
Copy link
Collaborator

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@manimitrah manimitrah requested a review from timkim July 8, 2024 06:19
Copy link

aem-code-sync bot commented Jul 8, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Collaborator

@timkim timkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, I thought we already have a similar block as embed?
https://github.com/adobe/adobe-io-website/blob/main/hlx_statics/blocks/embed/embed.js

Perhaps when we were creating the jira ticket for this, it was named Media in gatsby but Embed in eds so we didn't notice it was the same?

@manimitrah
Copy link
Collaborator Author

Hmmm, I thought we already have a similar block as embed? https://github.com/adobe/adobe-io-website/blob/main/hlx_statics/blocks/embed/embed.js

Perhaps when we were creating the jira ticket for this, it was named Media in gatsby but Embed in eds so we didn't notice it was the same?

@timkim , In Embedded You tube video is only possible to added , but in Media blocks We implement Both You Tube and Local Videos to be added. Can I remove the media blocks or it is ok with you for this update?

@timkim
Copy link
Collaborator

timkim commented Jul 19, 2024

Oh I see. Hmm our intern was actually working on embedding video from multiple sources (youtube, vimeo, tikitok, insta, local etc). I think we may end up using @Elisha-Edme work : #155. Sorry for the overlap! But if @Elisha-Edme , maybe you can browse the files in this pr and see if you missed anything that you'd like to add.

@Elisha-Edme
Copy link
Collaborator

@manimitrah Do you have a test file/link that you could add so that I could see the links that are allowed in this media block? It seems super similar to my PR but I'm not sure if local videos are a different format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants