Skip to content

Commit

Permalink
remove 'frame' from prohibited commands list
Browse files Browse the repository at this point in the history
Currently, 'frame' is prohibited on every architecture, even in gdb mode.
Since the passthrough is working on few architectures (eg. ppc64, and
vmss x86_64), so remove it from prohibited list, so that 'frame' command
can be used

This has an implication on all architectures, that 'frame' now outputs
this in default mode:

```
crash> frame
 #0  <unavailable> in ?? ()
```

instead of the before prohibited message

```
crash> frame
crash: prohibited gdb command: frame
```

Though, 'frame' should work in gdb mode for architectures that implement
'machdep->get_cpu_reg'

Cc: Sourabh Jain <[email protected]>
Cc: Hari Bathini <[email protected]>
Cc: Mahesh J Salgaonkar <[email protected]>
Cc: Naveen N. Rao <[email protected]>
Cc: Lianbo Jiang <[email protected]>
Cc: HAGIO KAZUHITO(萩尾 一仁) <[email protected]>
Cc: Tao Liu <[email protected]>
Signed-off-by: Aditya Gupta <[email protected]>
  • Loading branch information
adi-g15-ibm committed Mar 4, 2024
1 parent ac4e2ff commit fecf1c0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion gdb_interface.c
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,7 @@ static char *prohibited_list[] = {
"watch", "rwatch", "awatch", "attach", "continue", "c", "fg", "detach",
"finish", "handle", "interrupt", "jump", "kill", "next", "nexti",
"signal", "step", "s", "stepi", "target", "until", "delete",
"clear", "disable", "enable", "condition", "ignore", "frame", "catch",
"clear", "disable", "enable", "condition", "ignore", "catch",
"tcatch", "return", "file", "exec-file", "core-file", "symbol-file",
"load", "si", "ni", "shell", "sy",
NULL /* must be last */
Expand Down

0 comments on commit fecf1c0

Please sign in to comment.