Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of attaention catgories and causes #462 #470

Merged
merged 3 commits into from
May 17, 2024
Merged

Addition of attaention catgories and causes #462 #470

merged 3 commits into from
May 17, 2024

Conversation

erwinspeybroeck
Copy link
Collaborator

@erwinspeybroeck
Merge pull request #469 from adewg/Develop
8b7c653 
get to the develop branch
@erwinspeybroeck
Update icarAttentionCategoryType.json
2ee111b 
Added Reproduction, DeviceIsue and Weight as new categories
@erwinspeybroeck
Update icarAttentionCauseType.json
312e1ff 
Added new causes for the attention (Heat, LowBattery, Offline, UnderWeight, OverWeight, AtTargetWeight)
@erwinspeybroeck erwinspeybroeck requested a review from cookeac May 17, 2024 07:30
cookeac
cookeac approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@cookeac cookeac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. The linting checks fail but this is because of previous PRs. I will do a seperate PR to fix those.

@cookeac cookeac merged commit 373787f into Develop May 17, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cookeac cookeac cookeac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erwinspeybroeck @cookeac