-
Notifications
You must be signed in to change notification settings - Fork 119
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update PickerItem.tsx to allow values of type
number
(#74)
* Update PickerItem.tsx Allow values for the picker to be strings or numbers, so that I don't have to do custom transformation logic on the values. This is particularly useful for a picker for numeric values like height, where I really want to store it as a number and not a string. * Update corresponding types for value in Picker.tsx to support string | number also * Added type coersion in test. This works, but with this in mind it maybe better to allow the values to be generics if they aren't strings? Would be interested in thoughts
- Loading branch information
1 parent
dfc1f6e
commit 66b3018
Showing
4 changed files
with
9,044 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.