Remove register keyword as it has been deprecated since c++17 #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brahmajit Das <[email protected]>
Bug encontered on Gentoo with clang 16. Please refer https://bugs.gentoo.org/898574 Signed-off-by: Brahmajit Das <[email protected]>
yselkowitz
reviewed
Sep 9, 2024
| @@ -38,6 +38,6 @@ int tcp_wcommit(struct tcp_chan *chan, int); | |||
| int tcp_rskip(struct tcp_chan *chan,size_t); | |||
| int tcp_chan_has_data(struct tcp_chan *chan); | |||
|
|
|||
| extern time_t pbs_tcp_timeout; | |||
| extern "C" time_t pbs_tcp_timeout; | |||
There was a problem hiding this comment.
This causes an error with C, needs to be something like:
Suggested change
| extern "C" time_t pbs_tcp_timeout; | |
| #ifdef __cplusplus | |
| extern "C" time_t pbs_tcp_timeout; | |
| #else | |
| extern time_t pbs_tcp_timeout; | |
| #endif |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug encontered on Gentoo with clang 16. Please refer
https://bugs.gentoo.org/898574