The preq variable passed to svr_strtjob2 is the wrong request. #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld have been the AsyrunJob request but it is now the CopyFiles request to stage the files to the mom; and that request has been done and dealt with. Usually the ack later on to this request will not go through, as the file descriptor to which it was associated is already closed, but in some cases the fd has been reopened to start more jobs on the same worker node. In that case the ack is misinterpreted as a Connect request by the mom and the job commit will not go through, leaving jobs in a strange state. The fix in this commit mitigates the problem by preventing the ack from being sent.
|
@dvandok great catch on this bug. I'm looking into this and I want to do some testing to see if there are other pieces that need to be added here to complete the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should have been the AsyrunJob request but it is now the CopyFiles request to stage the
files to the mom; and that request has been done and dealt with. Usually the
ack later on to this request will not go through, as the file descriptor to
which it was associated is already closed, but in some cases the fd has been
reopened to start more jobs on the same worker node. In that case the ack
is misinterpreted as a Connect request by the mom and the job commit will not
go through, leaving jobs in a strange state. The fix in this commit mitigates
the problem by preventing the ack from being sent.
For a longer explaination see the wiki page I wrote.