Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #109 #589

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Fix #109 #589

merged 4 commits into from
Aug 13, 2024

Conversation

eb1
Copy link
Contributor

@eb1 eb1 commented Aug 13, 2024

Fixes #109 .

Changes proposed in this request:

  • Select phrase, start typing --> merge the phrase #109: Rework auto-merge feature that was tabled a while ago. This feature requires a Bluetooth keyboard, as the software / on-screen keyboard is not visible if there is no edit field in focus. The user selects the piles they want to merge into a phrase, and then starts typing on the keyboard -- AIM will merge the selected piles into a phrase, replacing the target text with what the user typed in.
  • Refactored the moveCursor() method to use the in-memory objects, and only stop on the next empty target. This should speed up the forward/back navigation, especially on chapters where there are sections of text that have already been adapted.

@adapt-it/developers

eb1 added 4 commits August 9, 2024 13:06
@eb1
Speed up moveCursor() processing
55b7fb6 
Use SourcePhrase models instead of DOM; only stop on empty target slots. This still needs more testing under FT/Gloss/empty verse scenarios.
@eb1
Add comparator (norder) to spList
ea1b4fd 
The Source Phrase list is returned ordered by norder, but adding/removing phrases, etc. is throwing the forward/back buttons off. Added a comparator so the list is re-sorted when the user adds/removes a phrase, etc.
@eb1
Possible fix for adapt-it#109
311a011 
- Revisit auto-merge phrase issue (adapt-it#109). This requires a Bluetooth KB to work, so it's a smaller use case; BUT it's a useful feature. Still need to test on the Android side before marking this fixed.
- Also fixed some logic errors with stripping punctuation / phrase interactions that came up during longevity testing. Still working through longevity tests.
@eb1
Helper method to delete duplicates from SP table
33b310a 
Not currently called.
@eb1 eb1 merged commit 0c3cf35 into adapt-it:master Aug 13, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select phrase, start typing --> merge the phrase
1 participant
@eb1