Changes for 1.14.0 #540
Merged
Changes for 1.14.0 #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ios and android platform if they don't exist before calling build on ios / android, respectively.
Need to update to node 16.x
Tasks still available if needed
Command line to add ios and android platforms working; also set the default gulpfile task to just build Android (for the CI build)
Try - force Gradle wrapper to the older (working) 7.3.1
try again...
eh, no promises...
Only compatible with browser platform (which we don't distribute)
typo
Another test
Note that this removes the actual compile. Might need to stop here if we can't get the server's build environment to cooperate. 👎
Start work on 1.14.0 (48)
Using a file chooser instead of scanning the local drives for file import. Usability improved 100-fold, BUT this required a lot of refactoring. Will probably be dealing with lurking bugs for a bit before this milestone can be released (and will need to be released in lock-step with the project file issue adapt-it#539).
Add an alert for when the clipboard is empty (or the user doesn't give permission to copy).
- Use chooser plugin to select project files (same work done for adapt-it#538). - Allow project import from clipboard (not a huge use case, but the work was already done for basic file import) - Add .aic filetype to Android supported file type lists Work still in progress.
Work on clipboard import of project files. Still in progress...
Work in progress. Also removed unused windows and firefoxos platform data, and expanded the chooser plugin's accepted files to */* for Android (logic to filter out unsupported file types is in the file import code)
Lost about a day tracking this down :/ SQLite plugin and the ES6 plugin used by social-sharing collide, causing AIM to not launch. There's a fork of social--sharing that removes this dependency.
Sanity import checks for .aic files: (1) test for existence of source/target language names (is it a valid .aic file?), return false if not found so file import can fall back on text import (2) if source/target language exist AND there is a project list, check each project to make sure we aren't importing a duplicate project (error out if we are).
Logic for multiple projects (ask the user if they want to switch projects at the end of the import)
Refactoring in progress -- moving import persistence to the model object (project::fromString()).
More refactoring of AIC file import...
Work in progress
refactoring import from projectviews->project object. projectViews now has a shell importSettingsFile() that calls project.fromString() to do the work.
missing errMsg definition
Set up iOS UTI declaration for AIC files, so users can open/import from another process on iOS.
Code cleanup -- a couple bugs in project management / copy project from file
Pretty close -- just need to get switching project from project mgt / copy new project working properly
Still need to test Android side, but final pieces of this issue have been implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # 538, 539.
Changes proposed in this request: