KB editor #523
Merged
KB editor #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split out KBView / TargetUnit template to service both a KB item view (without a selected source phrase) and a "Show Translations" screen (with a selected source phrase)
Fix "find in documents" for TU detail view
Fix a couple bugs in the TU item list / Find in Documents code, including an existing problem counting pre+foll puncts in search results.
For some weird reason, setting contenteditable was moving the scroll on the initial render for Find in Documents. Moved the call to set contenteditable up in the method, so that the scroll call doesn't get overridden.
Code checkpoint: Show Translations screen lookup code cleanup (add case and punct handling). Still need to handle adding refstrings / translations in-place.
More progress on new refstring code.
New RefString (new translation) working. Next up is New TU (net entry) code
TargetUnit.html to be used for new TU functionality as well
Apply similar styling to Add Translation button (add refstring)
Just updating some strings (other changes are local for now).
Code checkpoint. Updated language strings, and moved the New TU functionality to a wizard page. Work still in progress.
Yet more refactoring... not ready for testing.
Couple bug fixes. Still need to run end-to-end test.
Edit KB functionality done I think -- still needs end-to-end testing.
Last change here is to fix a bug in autoAddCaps that was causing weird duplicate entries for arrays (i.e., the typeahead dropdown)
Grr... forgot to add search functionality. Partially working now.
Getting search results back now. Still need to figure out paging mechanism for larger data sets.
Lots of re-plumbing for paged data retrieval. Separated sql row count into separate getCount() method, and added check for filters and isGloss flag. More to do...
Bug fixes -- some internal plumbing not connected properly. Still testing.
Remove extraneous call to fetch KB (Application.editTU()), as the KB should already have the TU in the collection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #507 .
Changes proposed in this request:
@adapt-it/developers