Skip to content

Commit

Permalink
Fixed a but where if the query string value for active is not 'true' …
Browse files Browse the repository at this point in the history
…lowercase the filter would fail.

Signed-off-by: Adam Yeager <Adam Yeager>
  • Loading branch information
Adam Yeager authored and Adam Yeager committed Jan 6, 2016
1 parent f437c09 commit fab5805
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 3 deletions.
18 changes: 18 additions & 0 deletions PushbulletSharp.Tests/PushTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -403,5 +403,23 @@ public void GetPushesSinceLastPush()
Assert.Fail(ex.Message);
}
}

[TestMethod]
public void GetPushesActive()
{
try
{
var filter = new PushResponseFilter()
{
Active = true
};

var results = Client.GetPushes(filter);
}
catch (Exception ex)
{
Assert.Fail(ex.Message);
}
}
}
}
4 changes: 2 additions & 2 deletions PushbulletSharp/Properties/AssemblyInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@
// You can specify all the values or you can default the Build and Revision Numbers
// by using the '*' as shown below:
// [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("2.3.2.0")]
[assembly: AssemblyFileVersion("2.3.2.0")]
[assembly: AssemblyVersion("2.3.3.0")]
[assembly: AssemblyFileVersion("2.3.3.0")]
2 changes: 1 addition & 1 deletion PushbulletSharp/PushbulletClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -781,7 +781,7 @@ public PushResponseContainer GetPushes(PushResponseFilter filter)

if (filter.Active != null)
{
string activeQueryString = string.Format("active={0}", (bool)filter.Active);
string activeQueryString = string.Format("active={0}", ((bool)filter.Active).ToString().ToLower());
queryStringList.Add(activeQueryString);
}

Expand Down

0 comments on commit fab5805

Please sign in to comment.