-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --notgame arg that omits -game flag in runAutomationCommands #23
base: master
Are you sure you want to change the base?
Conversation
Yes! This does it for me: One slightly sad thing for another day perhaps: |
@PaulHax At first glance that appears to be because |
@adamrehn Is there any chance of this making it into |
Apologies for the delay in responding to this pull request, I've been inordinately busy over the past couple of months and I'm only now making my way through my GitHub backlog. Please see my comment #22 (comment) for details of why I've avoided providing an option to disable passing the |
@adamrehn Thanks for the response, we'll likely maintain our own fork during the interim as the modification is behaving as expected in our limited use case. |
Problem
The automatic inclusion of the
-game
when calling the editor binary prevents use ofue4cli test
with editor plugins.Proposed solution
Include
-game
by default but enable its omission with a--notgame
flag. Potentially Resolves #22Notes
--enableeditor
Was misleading because it implies that the "UnrealEditor" is disabled.--editorplugin
Was misleading because other arguments would likely need to be used in conjunction with this argument for editor plugins--notgame
Seemed to be the most concise (please subject to scrutiny)@PaulHax test with