Skip to content

Commit

Permalink
Merge pull request etcd-io#7372 from gyuho/updates
Browse files Browse the repository at this point in the history
*: miscellaneous updates on release 3.2 cycle
  • Loading branch information
gyuho authored Feb 24, 2017
2 parents 9fbdd0a + 3eaf2f6 commit 833aa51
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ go_import_path: github.com/coreos/etcd
sudo: false

go:
- 1.7.4
- 1.8
- tip

notifications:
Expand Down
1 change: 1 addition & 0 deletions MAINTAINERS
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
Anthony Romano <[email protected]> (@heyitsanthony) pkg:*
Brandon Philips <[email protected]> (@philips) pkg:*
Fanmin Shi <[email protected]> (@fanminshi) pkg:*
Gyu-Ho Lee <[email protected]> (@gyuho) pkg:*
Xiang Li <[email protected]> (@xiang90) pkg:*

Expand Down
2 changes: 1 addition & 1 deletion e2e/etcd_release_upgrade_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ func TestReleaseUpgrade(t *testing.T) {
// so there's a window at boot time where it doesn't have V3rpcCapability enabled
// poll /version until etcdcluster is >2.3.x before making v3 requests
for i := 0; i < 7; i++ {
if err = cURLGet(epc, cURLReq{endpoint: "/version", expected: `"etcdcluster":"3.0`}); err != nil {
if err = cURLGet(epc, cURLReq{endpoint: "/version", expected: `"etcdcluster":"3.1`}); err != nil {
t.Logf("#%d: v3 is not ready yet (%v)", i, err)
time.Sleep(time.Second)
continue
Expand Down
12 changes: 6 additions & 6 deletions test
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
# PKG=./wal ./test
# PKG=snap ./test
#
# Run code coverage
# Run code coverage
# COVERDIR must either be a absolute path or a relative path to the etcd root
# COVERDIR=coverage PASSES="build_cov cov" ./test
set -e
Expand Down Expand Up @@ -84,7 +84,7 @@ function integration_pass {
function cov_pass {
echo "Running code coverage..."
# install gocovmerge before running code coverage from github.com/wadey/gocovmerge
# gocovmerge merges coverage files
# gocovmerge merges coverage files
if ! which gocovmerge >/dev/null; then
echo "gocovmerge not installed"
exit 255
Expand All @@ -103,7 +103,7 @@ function cov_pass {
mkdir -p "$COVERDIR"

# PKGS_DELIM contains all the core etcd pkgs delimited by ',' which will be profiled for code coverage.
# Integration tests will generate code coverage for those pkgs
# Integration tests will generate code coverage for those pkgs
PKGS_DELIM=$(echo $TEST | sed 's/ /,/g')

PKGS=`echo "$TEST_PKGS" | egrep -v "(e2e|functional-tester)"`
Expand All @@ -115,7 +115,7 @@ function cov_pass {
done

# run code coverage for e2e tests
# use 30m timeout because e2e coverage takes longer
# use 30m timeout because e2e coverage takes longer
# due to many tests cause etcd process to wait
# on leadership transfer timeout during gracefully shutdown
go test -tags cov -timeout 30m -v ${REPO_PATH}"/e2e"
Expand Down Expand Up @@ -151,7 +151,7 @@ function grpcproxy_pass {
function release_pass {
rm -f ./bin/etcd-last-release
# to grab latest patch release; bump this up for every minor release
UPGRADE_VER=$(git tag -l --sort=-version:refname "v3.0.*" | head -1)
UPGRADE_VER=$(git tag -l --sort=-version:refname "v3.1.*" | head -1)
if [ -n "$MANUAL_VER" ]; then
# in case, we need to test against different version
UPGRADE_VER=$MANUAL_VER
Expand Down Expand Up @@ -299,7 +299,7 @@ function build_cov_pass {
if [ -n "${BINDIR}" ]; then out="${BINDIR}"; fi
PKGS=$TEST
ETCD_PKGS_DELIM=$(echo $PKGS | sed 's/ /,/g')
go test -c -covermode=set -coverpkg=$ETCD_PKGS_DELIM -o ${out}/etcd_test
go test -c -covermode=set -coverpkg=$ETCD_PKGS_DELIM -o ${out}/etcd_test
}

function compile_pass {
Expand Down

0 comments on commit 833aa51

Please sign in to comment.