Ensure allow credentials header is not emitted for disallowed origins #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When request origin doesn't match allowed origins the library adds the "allow credentials" header which seems invalid or at least redundant. In this change we ensure the "allow credentials" header is only emitted when other CORS headers are.
adamchainz
force-pushed
the
romanek-adam-patch-1
branch
from
8594ee4
to
0e57b82
Compare
|
Thank you for the PR. I pushed some edits: moving the block down a little further for clarity, adding a regression test, and adding a changelog entry. Released in 4.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When request origin doesn't match allowed origins the library adds the "allow credentials" header which seems invalid or at least redundant. In this change we ensure the "allow credentials" header is only emitted when other CORS headers are.