-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTC Superclass #215
Open
Harrison-O
wants to merge
47
commits into
adafruit:master
Choose a base branch
from
Harrison-O:RTC_superclass
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
RTC Superclass #215
Changes from 25 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
cb0bf8d
Wrote `isLeapYear()` function
0af4be5
Wrote `fixDateTime()` method to fix invalid DateTime objects
6f49b2b
Write additional comment specifying that if DateTime is already valid,
bca61c2
Merge pull request #1 from Harrison-O/DateTime_eqaulity
Harrison-O ba9c0ed
Merge pull request #2 from Harrison-O/fixDateTime
Harrison-O ae82978
Merge pull request #3 from adafruit/master
Harrison-O dded178
Merge pull request #4 from Harrison-O/master
Harrison-O 7654480
Wrote RTC superclass
e3757d3
Modified RTClib.h to use RTC.h
9dfa49b
Fixed IDE errors
00075a4
Fixed compile errors
eaec406
Moved _I2C_WRITE and _I2C_READ to RTClib.cpp
68bed44
Wrote new keywords
54fcd63
Fixed usage of millisPerSecond and RTC_Millis::adjustDrift()
2b98009
Updated doxygen comments for adjustDrift()
4a25373
Wrote second `begin()` function for RTC classes
c1001bc
Wrote adjustDraft() functions for RTC classes
f00f0af
Removed adjustDrift() for future pull request
58e5432
Made RTC superclass public for subclasses
1614120
Fixed compile error with begin(const DateTime&)
de9a42e
Removed fixDateTime() function
189ddc9
Fixed file placement in utility folder
0975cc5
Ensured that TimeSpan.h file includes Arduino.h
3ab7669
Removed COMPILE_DT constant due to compile error
3721491
Removed adjustDrift() from RTC for future pull request
290bea2
Fixed build errors
41b522d
Fixed adjustDrift() for RTC_Millis
2f99da8
Fixed micro to milli typo
edc0af4
Fixed clang formatting issues
fd67d34
Wrote adjustDrift() back in to enforce consistency
80b5650
:w
7213586
Fixed clang formatting issues
5eba8f6
Removed millisPerSecond from RTC_Millis
db255bf
Fixed compile error involving millisPerSecond
e2a981c
Renamed RTC_Super to RTC to find RTC macro
8f7e656
Changed begin(DateTime&) to non-pure virtual
c13d1c4
Renamed RTC_Super to RTC_Base
56f3426
Changed begin(void) method for pseudo RTCs
678f814
Updated doxygen comment
2e664b4
Renamed RTC_Base to RealTimeClock
3151cf7
Wrote note for RealTimeClock class
b8d8b77
Changed ppm to non-const
266cc68
Made lostPower() virtual in base class
84fbf61
Commented out adjustDrift() for future versions
ad85753
Fixed clang formatting issue
5cee6ba
Fixed clang formatting issue
a5a037d
Fixed clang formatting issue
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not used anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed