Moved to actions, no doxygen #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ladyada Same here. Should I include the dependencies only used in examples in library.properties? |
|
yeah - some folks complain but for the vast majority its helpful! |
|
@ladyada Also, should I not test the esp32 and nrf52 on this library? The esp32 is missing softwareserial and the nrf52 is just failing because some stuff is being redefined |
PaintYourDragon
approved these changes
Jun 26, 2020
|
I’d suggest building for SAMD only. Maybe even just specific boards…Circuit Playground Express and try Metro M0 or something? The mentions of Serial1 and Wire1 imply post-AVR boards, and the PLL stuff is very device specific. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.