new CLI feature: maintain battery in a certain range #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* https://github.com/actuallymentor/battery: Fix bug Add files via upload cleared up logging message cleared up logging message added integer check for charge command argument
|
Thanks for the addition Seefood! If I read this correctly, the while loop has no throttling so would be running in very rapid succession. Was that a design decision? |
|
There's a 1 minute sleep there at the end of the while loop, so battery levels are sampled once a minute. Do you feel it should be more like 5 minutes? |
|
Hi, Just wanted to ask if PR is just waiting for the loop throttle/sleep fix or resolution? |
matiasanaya
reviewed
Nov 26, 2024
| if [[ "$lower_threshold" -lt 1 ]] || [[ "$lower_threshold" -gt 100 ]] || | ||
| [[ "$upper_threshold" -lt 1 ]] || [[ "$upper_threshold" -gt 100 ]] || | ||
| [[ "$lower_threshold" -gt "$upper_threshold" ]]; then | ||
| log "Error: $setting is not a valid range setting for battery maintain. The min/max value should between 1 and 100. A range example like 30-80" |
There was a problem hiding this comment.
The min/max value should be between 1 and 100.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug
Add files via upload
cleared up logging message
cleared up logging message
added integer check for charge command argument
Actually #227 by @tangb4c with some code improvements and inline comments