Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ruby/rails/activeadmin matrix #84

Merged
merged 5 commits into from
Dec 26, 2023
Merged

update ruby/rails/activeadmin matrix #84

merged 5 commits into from
Dec 26, 2023

Conversation

gigorok
Copy link
Collaborator

@gigorok gigorok commented Oct 24, 2023

  • remove ruby 2.5, 2.6 support
  • add ruby 3.0, 3.1, 3.2, 3.3 support
  • remove rails 5.2, 6.0 support
  • add rails 6.1, 7.0, 7.1 support
  • remove activeadmin 2.0, 2.6 support
  • add activeadmin 2.14, 3.0, 3.1, 3.2 support

ActiveAdmin <= 3.0 is incompatible with Rails >= 7.1, due to conflict with railties

@gigorok gigorok force-pushed the aa-v3-1 branch 9 times, most recently from 1c0e84f to 2b4e2bf Compare October 25, 2023 09:34
Copy link
Contributor

@workgena workgena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Feel free to merge (version bump we'll do in the follow up PR)

@gigorok
Copy link
Collaborator Author

gigorok commented Dec 11, 2023

Hello @workgena,
Thanks for your contribution!

What do you think about the next suggestions?

@senid231 senid231 self-requested a review December 14, 2023 08:49
@senid231 senid231 marked this pull request as ready for review December 14, 2023 08:49
@senid231 senid231 removed their request for review December 14, 2023 08:50
@workgena
Copy link
Contributor

workgena commented Dec 14, 2023

Hi, agree.

I also want to add one older version of ActiveAadmin (might make upgrade easier for people) and gem still has good compatibility with activeadmin 2.x

Matrix is "not mixed" and versions of Ruby/Rails/AA are composed manually, - it makes more sense in terms of how people use ActiveAdmin. // not 100% sure about this approach, but I like it more

Supported version:

  • Ruby
    • 3.0.z
    • 3.1.z
    • 3.2.z
    • 3.3.z
  • Ruby on Rails
    • 6.1.z
    • 7.0.z
    • 7.1.z
  • activeadmin
    • 2.14.0
    • 3.0.0
    • 3.1.0
    • 3.2.0

We can extend it if needed. For example, add Ruby 3.3 (but I don't know how to add preview version) Ruby 3.3 has been added.

@workgena
Copy link
Contributor

workgena commented Dec 26, 2023

Updated matrix of tested versions:

Ruby Rails ActiveAdmin status
3.0 6.1 2.14 ok
3.0 6.1 3.0 ok
3.0 6.1 3.1 ok
3.0 6.1 3.2 ok
3.0 7.0 2.14 ok
3.0 7.0 3.0 ok
3.0 7.0 3.1 ok
3.0 7.0 3.2 ok
3.0 7.1 2.14 -
3.0 7.1 3.0 -
3.0 7.1 3.1 ok
3.0 7.1 3.2 ok
3.1 6.1 2.14 ok
3.1 6.1 3.0 ok
3.1 6.1 3.1 ok
3.1 6.1 3.2 ok
3.1 7.0 2.14 ok
3.1 7.0 3.0 ok
3.1 7.0 3.1 ok
3.1 7.0 3.2 ok
3.1 7.1 2.14 -
3.1 7.1 3.0 -
3.1 7.1 3.1 ok
3.1 7.1 3.2 ok
3.2 6.1 2.14 ok
3.2 6.1 3.0 ok
3.2 6.1 3.1 ok
3.2 6.1 3.2 ok
3.2 7.0 2.14 ok
3.2 7.0 3.0 ok
3.2 7.0 3.1 ok
3.2 7.0 3.2 ok
3.2 7.1 2.14 -
3.2 7.1 3.0 -
3.2 7.1 3.1 ok
3.2 7.1 3.2 ok
3.3 6.1 2.14 ok
3.3 6.1 3.0 ok
3.3 6.1 3.1 ok
3.3 6.1 3.2 ok
3.3 7.0 2.14 ok
3.3 7.0 3.0 ok
3.3 7.0 3.1 ok
3.3 7.0 3.2 ok
3.3 7.1 2.14 -
3.3 7.1 3.0 -
3.3 7.1 3.1 ok
3.3 7.1 3.2 ok

ActiveAdmin <= 3.0 is incompatible with Rails >= 7.1, due to conflict with railties:

activeadmin (~> 2.14.0) x86_64-linux was resolved to 2.14.0, which depends
on
      railties (< 7.1, >= 6.1)

    rails (~> 7.1.0) x86_64-linux was resolved to 7.1.0, which depends on
      railties (= 7.1.0)

@workgena workgena removed the request for review from senid231 December 26, 2023 20:01
@gigorok gigorok merged commit a5fccff into master Dec 26, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants