Renamed GRASS GIS locations to projects #565
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmacata
reviewed
Nov 14, 2024
mmacata
reviewed
Nov 14, 2024
src/actinia_core/processing/actinia_processing/ephemeral/download_cache_management.py
Outdated
Show resolved
Hide resolved
mmacata
reviewed
Nov 14, 2024
mmacata
reviewed
Nov 14, 2024
mmacata
reviewed
Nov 14, 2024
mmacata
reviewed
Nov 14, 2024
mmacata
reviewed
Nov 14, 2024
mmacata
reviewed
Nov 14, 2024
mmacata
reviewed
Nov 15, 2024
mmacata
reviewed
Nov 15, 2024
mmacata
reviewed
Nov 15, 2024
Co-authored-by: Carmen Tawalika <[email protected]>
mmacata
reviewed
Nov 15, 2024
mmacata
reviewed
Nov 15, 2024
| grass_version_s = G_VERSION["version"] | ||
| grass_version = [int(item) for item in grass_version_s.split(".")[:2]] | ||
| if grass_version >= [8, 4]: | ||
| param["projects"] = projects |
There was a problem hiding this comment.
This might break with LocationListResponseModel
There was a problem hiding this comment.
Fine if this PR stays open as long as it takes to also adjust actinia-api but I would suggest to do adjustments in a separate PR.
…re into renamed_locations
mmacata
reviewed
Nov 15, 2024
mmacata
reviewed
Nov 15, 2024
mmacata
reviewed
Nov 15, 2024
| "endpoint": http_request.endpoint, | ||
| # For depricated location endpoints remove "_locations" from | ||
| # endpoint class name | ||
| "endpoint": http_request.endpoint.replace("_locations", ""), |
There was a problem hiding this comment.
It is needed because I can't add two urls for one endpoint. The endpoint is inside the actinia response and is used for the job jesumption.
mmacata
reviewed
Nov 15, 2024
mmacata
reviewed
Nov 15, 2024
| "endpoint": request.endpoint, | ||
| # For depricated location endpoints remove "_locations" from | ||
| # endpoint class name | ||
| "endpoint": request.endpoint.replace("_locations", ""), |
There was a problem hiding this comment.
And here? I guess for the same reason 🙃
Co-authored-by: Carmen Tawalika <[email protected]>
…re into renamed_locations
Co-authored-by: Carmen Tawalika <[email protected]>
…re into renamed_locations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed GRASS GIS locations to projects from GRASS GIS version 8.4: