Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove generated files from bad merge #302

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Dec 23, 2024

Bad merge commit from a while ago 2abb062

Overall, the diff between this repo and datahub-project/datahub should be very small. None of these files exist in the latter.

Can view the existing diff here datahub-project/datahub@master...acryldata:datahub:master

After this change, these are the files with any diff

.github/pull.yml
.github/scripts/docker_helpers.sh
.github/workflows/auto-approve-prs.yml
.github/workflows/codeql.yml
.github/workflows/contributor-open-pr-comment.yml
.github/workflows/docker-airflow-acryl.yml
.github/workflows/docker-unified.yml
.github/workflows/documentation.yml
.github/workflows/publish-airflow-plugin-pypi-release.yml
.github/workflows/publish-dagster-plugin-pypi-release.yml
.github/workflows/publish-datahub-jars.yml
.github/workflows/publish-gx-plugin-pypi-release.yml
.github/workflows/publish-pypi-release.yml
docker/airflow/Dockerfile
docker/airflow/docker-compose.yaml
docs-website/docusaurus.config.js

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Bad merge commit from a while ago 2abb062

Overall, the diff between this repo and datahub-project/datahub should be very small. None of these files exist in the latter.
Copy link

Hello @hsheth2 😄

Thank you so much for opening a pull request!

Image
You can check out your contributor card and see all your past stats here!

@hsheth2 hsheth2 merged commit 91e96ee into master Dec 23, 2024
10 checks passed
@hsheth2 hsheth2 deleted the remove-generated-files branch December 23, 2024 23:42
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.09%. Comparing base (5ec0ec9) to head (ddb7515).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (5ec0ec9) and HEAD (ddb7515). Click for more details.

HEAD has 19 uploads less than BASE
Flag BASE (5ec0ec9) HEAD (ddb7515)
prefect 3 0
prefect-3.10 1 0
prefect-3.9 1 0
dagster-3.10-dagster>=1.3.3 1 0
dagster-3.9-dagster>=1.3.3 1 0
prefect-3.8 1 0
gx-3.11-great-expectations~=0.18.0 1 0
gx-3.11-great-expectations~=0.17.0 1 0
gx-3.8-great-expectations~=0.15.12 1 0
gx-3.10-great-expectations~=0.16.0 numpy~=1.26.0 1 0
airflow-test-airflow23 1 0
airflow 2 0
pytest-testQuick 1 0
airflow-test-airflow24 1 0
pytest-testIntegrationBatch1 1 0
pytest-testIntegrationBatch0 1 0
Additional details and impacted files

see 1858 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ec0ec9...ddb7515. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants