feat(airflow) Override datajob external_url #274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gp1105739 I'm trying to understand what override_datajob_url might get set to - looks like it's supposed to be a template URL? |
@hsheth2 Sure, it can be something similar to |
hsheth2
reviewed
Jan 17, 2024
There was a problem hiding this comment.
Could you open this PR against https://github.com/datahub-project/datahub instead of this repo?
...data-ingestion-modules/airflow-plugin/src/datahub_airflow_plugin/client/airflow_generator.py
Show resolved
Hide resolved
metadata-ingestion-modules/airflow-plugin/src/datahub_airflow_plugin/_config.py
Show resolved
Hide resolved
| @@ -41,6 +41,9 @@ class DatahubLineageConfig(ConfigModel): | |||
| # The Airflow plugin behaves as if it were set to True. | |||
| graceful_exceptions: bool = True | |||
|
|
|||
| # Override the external urls of datajob. | |||
| override_datajob_url: str = None | |||
|
|
|||
| def make_emitter_hook(self) -> "DatahubGenericHook": | |||
There was a problem hiding this comment.
configs also need to be added to get_lineage_config below, and also added to the docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current url link may not be that useful for the two reasons following, which is why this pr is brought up.
Checklist